Comments on: Conditional Import Text Files

By: JP

JP — Fri, 14 Aug 2009 23:53:04 +0000

What's the error message?

By: Norhaya

Norhaya — Fri, 14 Aug 2009 04:26:57 +0000

I've an error on this line

ReDim Preserve vArray(1 To lNextRow, 1 To 1))

By: Jon Peltier

Jon Peltier — Thu, 28 Aug 2008 03:06:30 +0000

JP – lNextRow updates here after the condition is tested and passes:

If (Left$(strLine, 3) = “ABC”) Then
lNextRow = 1 + lNextRow

By: JP

JP — Wed, 27 Aug 2008 16:59:05 +0000

I like your code better, but where do you see lNextRow being incremented? It's based on "WorksheetFunction.CountA(Range("A:A"))", which wouldn't change if we didn't write the line to the worksheet. --JP

By: Jon Peltier

Jon Peltier — Tue, 26 Aug 2008 21:43:15 +0000

Instead of writing each line to the sheet as it is approved, write it to an array. Then at the end of the procedure, dump the array in one operation to the worksheet.

(Also, your original code increments lNextRow even if the input value for that row is not approved.)

Sub ConditionalImport()
Dim lNum As Long
Dim strLine As String
Dim lNextRow As Long
dim vArray() as Variant

Application.ScreenUpdating = False

' get number of next free file
lNum = FreeFile

' open text file for input, loop through each line,
' only import rows we need

Open "C:\testfile.txt" For Input As #lNum
lNextRow = 0
ReDim vArray(1 To 1, 1 To 1)
Do While Not EOF(lNum)
Line Input #lNum, strLine

If (Left$(strLine, 3) = "ABC") Then
lNextRow = 1 + lNextRow
ReDim Preserve vArray(1 To lNextRow, 1 To 1))
Cells(lNextRow + 1, 1).Value = strLine
End If

Loop

ActiveSheet.Cells(1, 1).Resize(lNextRow).Value = vArray

Close lNum

Application.ScreenUpdating = True
End Sub